Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ocrd_utils: adapt to newer importlib.resources API #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kba merged 1 commit into from
Mar 15, 2023
Merged

ocrd_utils: adapt to newer importlib.resources API #996

kba merged 1 commit into from
Mar 15, 2023

Conversation

@bertsky
Copy link
Collaborator

@bertsky bertsky commented Mar 14, 2023

fixes #995

@kba kba merged commit 29643b7 into master Mar 15, 2023
@bertsky
Copy link
Collaborator Author

bertsky commented Mar 15, 2023

Ouch!

So on Py38 we already have importlib.resources, but not the new files API!

@bertsky
Copy link
Collaborator Author

bertsky commented Mar 15, 2023

So on Py38 we already have importlib.resources, but not the new files API!

To fix this we therefore must replace the <3.8 with a <=3.8 (or with <3.9) in

core/ocrd_utils/requirements.txt

Line 7 in 432d852

importlib_resources;python_version<'3.8'

@kba
Copy link
Member

kba commented Mar 15, 2023

I will fix it once I get the docker images built.

@bertsky
Copy link
Collaborator Author

bertsky commented Mar 15, 2023

I will fix it once I get the docker images built.

What do you mean? Merge #986?

The problem I just described is affecting the Docker build.

@kba
Copy link
Member

kba commented Mar 15, 2023

I will fix it once I get the docker images built.

What do you mean? Merge #986?

Yes

The problem I just described is affecting the Docker build.

I meant, I will debug this in the context of #986.

kba added a commit that referenced this pull request Mar 15, 2023
@kba
require importlib_resources for python <= 3.8, #996
8e9efaf
@kba kba deleted the importlib-resources-update branch March 15, 2023 16:38
kba added a commit that referenced this pull request Mar 15, 2023
@kba
require importlib_resources for python <= 3.8, #996
a73c7fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kba kba kba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ocrd_utils.resource_string: importlib.resources.read_binary deprecated

3 participants

@bertsky @kba