avoid forcing opencv and numpy updates #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note: I have tried to fix the CUDA build here, too, because the CUDA version is used for CI anyway. For now I have not seen problems with missing downwards compatibility yet, but perhaps my testing was not thorough enough (and it's difficult to keep track of all the open ends at the same time. |
kba
approved these changes
Mar 22, 2023
Member
kba
left a comment
There was a problem hiding this comment.
Agreed, I will focus on getting the docker setup fixed and ocrd_all release finished tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
385c595 (Mike's trick to speed up OpenCV and Numpy builds on older Python) should have been formulated without the
--updatehere, as it turns out this unfortunately interferes with numpy version conflicts between TF and H5py.