-
Notifications
You must be signed in to change notification settings - Fork 33
bashlib: make input-files n-ary #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: usage is as follows:
For a full example, see https://github.com/UB-Mannheim/ocrd_pagetopdf/pull/22 |
Since I will probably rewrite ocrd-pagetopdf to not use multiple input fileGrps anymore, we could use another example for this capability. How about some generic bashlib processor in tests which merely does a |
kba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good way to ensure backwards-compatibility and support multiple input file groups, even if they're not necessary for ocrd_pagetopdf anymore.
Can you add this as a comment to |
- explain outputFileId - explain ocrd__argv and params - explain main loop pattern - explain multi-valued input fileGrp
|
|
sorry for the noise – was too lazy to do it locally |
|
fixes #413 |
it's really strange: I cannot link to this issue (in text or directly in |
Apparently so, I cannot link them either... |
|
Finally got it working – ready to be merged 😓 |
|
CI: now only macos failure remains. |
|
I struggle to fix the macos test, now it's complaining that |
|
@kba can we please make a quick release 2.50 out of the current master? Remember that in https://github.com/UB-Mannheim/ocrd_pagetopdf/pull/22 I had to require a new 2.50 for the n-ary bashlib fix. |
fixes #1027