ocrd-network: optional deploy mongodb and queue #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python3-pip can now be removed, and running pip instead of pip3 is sufficient. This also avoids the installation of python3-setuptools and python3-wheel (requirements of python3-pip). Signed-off-by: Stefan Weil <[email protected]>
…stem-wide via ld.so.conf
…ckerfile for that
Previously mongodb credentials from config were accidentially ignored and it was always deployed without credentials
Collaborator
Contributor
Author
Contributor
Contributor
Author
|
Edit: found it and changed the base of this PR (via github gui). Hopefully this is what was meant because i didn't rebase anything for that. |
MehmedGIT
reviewed
May 10, 2023
MehmedGIT
reviewed
May 15, 2023
Contributor
MehmedGIT
left a comment
There was a problem hiding this comment.
Looks good to me and can be merged.
- extra Dockerfile.cuda instead of guessing from base image name - re-use non-CUDA ocrd/core instead of nvidia/cuda base image - install CUDA toolkit and libraries via (micro)mamba instead of nvidia-pyindex CUDA libraries made available system-wide - get cuDNN and CUDA libs from conda-forge and nvidia channels
- install CUDA libraries via nvidia-pyindex again (but not nvcc) - ensure they can be compiled/linked against system-wide (with nvcc)
(only cosmetic)
docker-cuda: move recipe to reusable makefile target deps-cuda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft for now for easier usage.
This is an extensions to 1030.
With this mongoDB and rabbitMQ can be skipped with the deployer to allow self management of this two parts/containers.
For the deployment on the VM I want to change to self managed queue and database so I need this therefore.