Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bertsky
Copy link
Collaborator

@bertsky bertsky commented Jun 2, 2023

Since python setup.py sdist bdist_wheel is deprecated, this uses build instead. Also, it turns out, we forgot to add our requirements.txt to the manifest (and ocrd.processor.builtin.dummy as a package) for correct packaging. Further improves the makefile.

Note: in the long run we should

  • switch to pyproject.toml, with setuptools as build backend, and setup.cfg
  • move requirements.txt to the latter's install_requires key, and either abandon requirements.txt or keep it for dev purposes (with a workable state of pip freeze)
  • tie versioning to git tags (so there will be no need for manual synchronization anymore, and not interdependencies at build time) via setuptools_scm recipe – see this example

@bertsky bertsky requested a review from kba June 2, 2023 22:59
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kba kba force-pushed the improve-packaging branch from 1ba174e to 29e79ad Compare June 26, 2023 16:06
@kba kba merged commit 29e79ad into OCR-D:master Jun 26, 2023
@bertsky bertsky deleted the improve-packaging branch June 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants