Workspace validator page checks loop #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kba
approved these changes
Jul 10, 2023
Member
kba
left a comment
There was a problem hiding this comment.
Obviously more efficient like this.
The main reason why these are private methods is that it keeps the interface small and allows for a single location where _resolve_workspace is called. If we add that to the individual methods (subsequent calls become a no-op once self.workspace is set), we could make them public.
Co-authored-by: Konstantin Baierer <[email protected]>
# Conflicts: # src/ocrd_validators/workspace_validator.py
Member
|
I know this is a draft but it is a useful improvement even without further changes to the API - can we merge? |
Collaborator
Author
Sure. Will try to be more bold next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be discussed, but the current code is inefficient and hard to reuse.
Since the existing functions are all private anyway, perhaps we could be more bold here and encapsulate each single PAGE check with a public member in PageValidator?