ocrd_utils.config to handle all environment variables #1081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been accumulating quite a lot of environment variables that define behavior in addition to the CLI options and other explicit mechanisms in the codebase. @bertsky started documenting all of those in 2d85503 and this PR goes a step further to bundle all the functionality and documentation in one place.
In
ocrd_utils.config, there is a singleton instanceconfigofocrd_utils.config.OcrdEnvConfigthat should be used for registering environment variables and parsing them.For example to define a new environemnt variable
OCRD_LOGGING_CONFIG, we register it:This environment variable can now be accessed as
config.OCRD_LOGGING_CONFIGwhich will return apathlib.Pathbecause theparser. Since we're definingvalidator, this will fail as soon asconfig.OCRD_LOGGING_CONFIGis accessed, if the value is not an existing file andconfig.OCRD_LOGGING.CONFIGwill return aPath.From the
descriptionfield, we generate the epilog to theocrd --helpoutput listing all the variables.In short, whenever we need a new environment variable
X:ocrd_utils.configconfig.X