-
Notifications
You must be signed in to change notification settings - Fork 33
Workflow endpoint logging 2023 09 26 #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test failure is due to connection issue, tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I ran a workflow to check if everything was logged properly I saw that only 2 main things were missing:
The FastAPI and Uvicorn logging - already suggested a solution.- Resolved!- The logging that comes from the OCR-D processors is suppressed. I am not sure about the fix. This is the logging that is redirected by the Deployer with the
xyzhack to get thepid. You can check the log files with the pattern/tmp/deployed_*to see they have just 2 lines each - the initialization part.
Co-authored-by: Mehmed Mustafa <[email protected]>
…-D/core into workflow-endpoint-logging-2023-09-26
|
What is still missing/not working properly regarding the logging (potentially new issues to be created):
Suggestions:
|
For For How about we add a processor-wide Once we have instantiated the processor, we can add a |
Not sure if that would be enough for what we are trying to achieve. Sure adding a |
|
After #1109, now it is clear how we can achieve processing job level file logging. |
This includes #1101 and updates the default config, builtin and config file, to offer the same behavior as the hard-coded logging
ocrd_network.I did add a file handler for the processing serverlog, as it was before, so you get the idea on how to adapt the server cache logging as well.
I did not remove the hard-coded logging configuration in ocrd_network though, since @MehmedGIT & @joschrew know best what the exact behavior should be.
The easies way to fine-tune the logging setup is to copy
ocrd_utils/ocrd_logging.confto$PWD(or$HOME), then remove the coded logging setup and translate it into the config file syntax and add your changes to this PR, then we can merge it to #1083 (as this PR proposes) or into master if we decide to merge #1089 into master before finishing the logging stuff.Ideally, we should change the root logger from
ocrd_networktoocrd.network. That way, we only need one logger definition but it's not urgent.