Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MehmedGIT
Copy link
Contributor

Fix for #1119

Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was an intermediate state I forgot to fix. LGTM

@kba kba merged commit 46b601b into master Oct 18, 2023
@MehmedGIT MehmedGIT deleted the fix-1119 branch December 12, 2023 13:39
@bertsky
Copy link
Collaborator

bertsky commented Aug 27, 2024

@kba @MehmedGIT the --log-filename is still in the general CLI though. It is still used for the processing worker (and the server), but comes in via configuration option NetworkLoggingDirs.PROCESSING_JOBS instead of the CLI. Since it was on the main processor CLI, I thought it was a mistake and added it to #1240 in 4f88f1d. Do we really want that, though? If yes, then I must reinstante the bashlib side as well.

@MehmedGIT
Copy link
Contributor Author

MehmedGIT commented Aug 27, 2024

@bertsky The ocrd_network logging should have nothing to do with the --log-filename flag coming from the general CLI. That is not passed down to the ProcessingWorker instance. I think that is a leftover from old code and should be removed. Unless the user wants to forward their logs to a separate file with the CLI (not with the ocrd_network cli!) - in that case it is fine.

We have structured logging in the ocrd_network. NetworkLoggingDirs.PROCESSING_JOBS is just a directory constant for processing job logs. Each processing job log file is stored inside with a unique name: {job_id}.log. When the ProcessingWorker invokes a processing job with run_processor or run_cli, the ProcessingWorker passes the unique job log file name as a parameter. Each ProcessingWorker also has its log file (f"{AgentType.PROCESSING_WORKER}.{pid}.{processor_name}.log") and these are stored under NetworkLoggingDirs.PROCESSING_WORKERS.

@bertsky
Copy link
Collaborator

bertsky commented Aug 27, 2024

I'll take that as a yes and will re-instante the option for bashlib (but only for the processing case, not networking).

@MehmedGIT
Copy link
Contributor Author

(but only for the processing case, not networking)

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants