Change api processor paths in ocrd_network #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MehmedGIT
approved these changes
Nov 15, 2023
Contributor
MehmedGIT
left a comment
There was a problem hiding this comment.
Looks good. What about the endpoints of the Processor Server? We have not talked about it on Monday, but IMO it makes sense to adapt the same changes there as well. E.g., /{job_id} would become /info/{job_id}.
Contributor
|
I should not forget to update the workflow endpoint guide once we have this merged. |
kba
approved these changes
Nov 15, 2023
Member
kba
left a comment
There was a problem hiding this comment.
LGTM, thanks @joschrew. I second @MehmedGIT, let's also change the processor server endpoints while we're at it.
Contributor
Author
|
good point, I will add it |
Align to changes made to processing-server so that endpoints are accessed in similar manner. Additionally fixed some bugs found while testing
MehmedGIT
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to simplify the api for handling processor requests.
processor_nameis removed where it is not needed and the remaining paths are adapted to that.As discussed on Monday. Separate PR for workflow will follow later.