defaults for mets_basename and mets_server_url #1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MehmedGIT
approved these changes
Dec 14, 2023
Contributor
MehmedGIT
left a comment
There was a problem hiding this comment.
Looks good. I am just wondering if the mets.xml literals in test_workspace_bagger.py are intentional?
Member
Author
Good point, I did not change the tests because I think it makes sense to hardcode constants in tests, and also to make sure I noticed if any tests break. I think it's best to leave the tests as they are for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in slub/mets-mods2tei#68, the
cli.workspace.WorkspaceCtxclass andResolver.resolve_mets_argumentsmethod now have defaults formets_basenameandmets_server_url.Also, I replaced all hard-coded
metx.xmlwith a constantDEFAULT_METS_BASENAMEto avoid typos and make it easier to spot where we assume the default basename.