ocrd_network base integration tests #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kba
approved these changes
Jan 30, 2024
Member
kba
left a comment
There was a problem hiding this comment.
Excellent, great work. a few minor questions, but ready for merge AFAICS. I'm running the tests and making sure that the multi-stage setup does not interfere with our other Docker deployments.
macos: I'll try to get it to work but it's not a blocker.
Comment on lines
+21
to
+25
| healthcheck: | ||
| test: echo 'db.runCommand("ping").ok' | mongosh localhost:27017/test --quiet | ||
| interval: 1s | ||
| timeout: 3s | ||
| retries: 30 |
Member
There was a problem hiding this comment.
Nice, that is a useful pattern we should apply widely.
Contributor
Author
There was a problem hiding this comment.
If that works, I prefer using that instead of sleeping here and there to wait. So far I have not seen issues with that health check here and in Operandi.
joschrew
reviewed
Jan 30, 2024
joschrew
reviewed
Jan 30, 2024
joschrew
approved these changes
Jan 30, 2024
Contributor
Author
|
Good to be shipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a basic beginning for the
ocrd_networkintegration tests.What does this PR include:
ocrd_networkfor easier testing of the DB functionalitiesUNSETfor jobs for easier testing instead of relying onNone/for just testing the connectivity to the Processing Server/workflow/job-simple/{workflow_job_id}- simplified endpoint for checking the overall status of a workflowocrd-dummyprocessor and queue by default when started:ocrd_networkand adding a dedicated endpointconftest.pyprovided for using fixtures for the MongoDB and RabbitMQocrd-dummyprocessorsocrd-dummy(1 processing worker deployed)ocrd_logging.conffor the ocrd_network integration tests for easier catching of bugs when tests are failing.dockerignoreto include relevant parts for the testsocrd_core_testimage to be used by the testing containersmake integration-testcall