Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rettinghaus
Copy link

This PR adds Python 3.12 to the test runs and updates the used GH actions.
Supersedes #1205

@rettinghaus rettinghaus mentioned this pull request Apr 10, 2024
Copy link
Contributor

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good and are required to fix the CI annotations. Thank you!

Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we should use the latest versions of the actions.

@stweil
Copy link
Contributor

stweil commented Apr 16, 2024

Citing https://peps.python.org/pep-0632/:

The distutils module [1] has for a long time recommended using the setuptools package [2] instead. Setuptools has recently integrated a complete copy of distutils and is no longer dependent on the standard library [3]. Pip has been silently replacing distutils with setuptools when installing packages for a long time already, and the distutils documentation has stated that it is being phased out since 2014 (or earlier). It is time to remove it from the standard library.

core still uses distutils. Therefore tests with Python 3.12 now fail.

@kba
Copy link
Member

kba commented Apr 16, 2024

Citing https://peps.python.org/pep-0632/:

The distutils module [1] has for a long time recommended using the setuptools package [2] instead. Setuptools has recently integrated a complete copy of distutils and is no longer dependent on the standard library [3]. Pip has been silently replacing distutils with setuptools when installing packages for a long time already, and the distutils documentation has stated that it is being phased out since 2014 (or earlier). It is time to remove it from the standard library.

core still uses distutils. Therefore tests with Python 3.12 now fail.

I have a branch which removes distutils. The find_executable replacement is straightforward, I still need to test the copy_tree replacement.

@stweil
Copy link
Contributor

stweil commented Apr 16, 2024

@rettinghaus, why did you remove Python 3.12 in your latest commit? I think it is good to have a CI test with that version.

@stweil
Copy link
Contributor

stweil commented Apr 16, 2024

@kba, I suggest to merge this pull request (without the last commit which removed Python 3.12 from the test matrix).

@rettinghaus
Copy link
Author

@stweil rebased and dropped last commit.

@kba kba merged commit df77ace into OCR-D:master May 3, 2024
@rettinghaus rettinghaus deleted the update/workflows branch May 4, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants