Thanks to visit codestin.com
Credit goes to github.com

Skip to content

drop ocrd-distributed resource_list.yml for good #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kba merged 2 commits into from
Aug 27, 2025
Merged

drop ocrd-distributed resource_list.yml for good #1322

kba merged 2 commits into from
Aug 27, 2025

Conversation

@bertsky
Copy link
Collaborator

@bertsky bertsky commented Apr 10, 2025

on the way to our refactoring: I think this must happen now.

We had decentralised resources for a while now. No-one is using the central ones (they are either out-of-date or redundant). And they hurt the user experience, e.g. when doing docker run ocrd/core ocrd resmgr list-installed (which could also be in any derived stage, think slim containers):

23:21:05.571 ERROR ocrd.utils.get_moduledir - ocrd-calamari-recognize --dump-module-dir failed: [Errno 2] No such file or directory: 'ocrd-calamari-recognize'
23:21:05.577 ERROR ocrd.utils.get_ocrd_tool_json - ocrd-calamari-recognize --dump-json produced invalid JSON: [Errno 2] No such file or directory: 'ocrd-calamari-recognize'
23:21:05.582 ERROR ocrd.utils.get_moduledir - ocrd-sbb-binarize --dump-module-dir failed: [Errno 2] No such file or directory: 'ocrd-sbb-binarize'
23:21:05.586 ERROR ocrd.utils.get_ocrd_tool_json - ocrd-sbb-binarize --dump-json produced invalid JSON: [Errno 2] No such file or directory: 'ocrd-sbb-binarize'
23:21:05.590 ERROR ocrd.utils.get_moduledir - ocrd-cis-ocropy-recognize --dump-module-dir failed: [Errno 2] No such file or directory: 'ocrd-cis-ocropy-recognize'
23:21:05.595 ERROR ocrd.utils.get_ocrd_tool_json - ocrd-cis-ocropy-recognize --dump-json produced invalid JSON: [Errno 2] No such file or directory: 'ocrd-cis-ocropy-recognize'
ocrd-calamari-recognize

ocrd-sbb-binarize

ocrd-cis-ocropy-recognize

So this is saying that core expects these 4 processors to be installed, just because it knows resources about them.

This commit removes the facility. (So this is independent of whether we still want to keep a user database facility.)

@bertsky bertsky requested review from MehmedGIT and kba and removed request for MehmedGIT April 10, 2025 23:38
kba
kba approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it was useful in the beginning when we did not have the distributed, ocrd-tool-based resources in place. Now it is just a source of bugs.

MehmedGIT
MehmedGIT approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@MehmedGIT MehmedGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it should be removed.

@kba kba changed the base branch from 1294-impl-rm-server-revert-revert to master April 30, 2025 15:24
@kba kba changed the base branch from master to 1294-impl-rm-server-revert-revert April 30, 2025 15:26
@kba kba merged commit 90568c7 into OCR-D:1294-impl-rm-server-revert-revert Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kba kba kba approved these changes

@MehmedGIT MehmedGIT MehmedGIT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bertsky @kba @MehmedGIT