Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a case of not seeing the forest for the trees: In the v3 changes, we did introduce
MissingInputFileexception (forOCRD_MISSING_INPUT=ABORT). But that only applied narrowly: iff there is nomets:filein one of the input fileGrps.However, the more important case seems to be that there is a
mets:file(regardless of the number of input fileGrps), but it is not available locally, andOCRD_DOWNLOAD_INPUT=Falsewas set deliberately – to either triggerOCRD_MISSING_INPUT=ABORTorOCRD_MISSING_INPUT=SKIP.But we did not implement this case yet – instead, we let the function proceed without download, which will then fail (without the
SKIPbehaviour) atpage_from_file.So now the ABORT and SKIP behaviours are enforced for locally missing files, too.