Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bertsky
Copy link
Collaborator

@bertsky bertsky commented May 7, 2025

This is a case of not seeing the forest for the trees: In the v3 changes, we did introduce MissingInputFile exception (for OCRD_MISSING_INPUT=ABORT). But that only applied narrowly: iff there is no mets:file in one of the input fileGrps.

However, the more important case seems to be that there is a mets:file (regardless of the number of input fileGrps), but it is not available locally, and OCRD_DOWNLOAD_INPUT=False was set deliberately – to either trigger OCRD_MISSING_INPUT=ABORT or OCRD_MISSING_INPUT=SKIP.

But we did not implement this case yet – instead, we let the function proceed without download, which will then fail (without the SKIP behaviour) at page_from_file.

So now the ABORT and SKIP behaviours are enforced for locally missing files, too.

@bertsky bertsky requested a review from kba May 7, 2025 23:08
@bertsky
Copy link
Collaborator Author

bertsky commented May 21, 2025

I don't understand what's going on with the network integration tests...

@kba kba merged commit 5ef2ea1 into OCR-D:master Jun 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants