Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bertsky
Copy link
Collaborator

@bertsky bertsky commented Jun 18, 2025

attempts to fix the recent CI failures of the network integration test

@bertsky bertsky requested a review from MehmedGIT June 19, 2025 00:21
@bertsky
Copy link
Collaborator Author

bertsky commented Jun 19, 2025

Ideally we should also add some direct tests for the worker CLIs. And when the network integration services do not start up successfully, we still need a proper error message... (currently just the docker exec ... pytest waits indefinitely)

Copy link
Contributor

@MehmedGIT MehmedGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should also add some direct tests for the worker CLIs.

What exactly do you mean with that?

And when the network integration services do not start up successfully, we still need a proper error message... (currently just the docker exec ... pytest waits indefinitely)

Would it help if all docker test container logs of the processing server and processing workers are written to a file, the printed by the ocrd_core_test instance instead of yes?

@bertsky
Copy link
Collaborator Author

bertsky commented Jun 19, 2025

Ideally we should also add some direct tests for the worker CLIs.

What exactly do you mean with that?

A new test case for the processor CLI like ocrd-dummy worker --help and ocrd-dummy worker --database mongodb://... --queue amqp://...

And when the network integration services do not start up successfully, we still need a proper error message... (currently just the docker exec ... pytest waits indefinitely)

Would it help if all docker test container logs of the processing server and processing workers are written to a file, the printed by the ocrd_core_test instance instead of yes?

Yes! That would be ideal. With that we could directly timeout 40s grep in the log file for certain events before running pytest.

@kba kba merged commit ceeeea4 into OCR-D:master Jun 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants