pin numpy<2 shapely <2.0.2 for py3.8 #1332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the shapely compile error issue that I (and the ocrd_all CI encounter with python 3.8.
For Python <= 3.8:
numpy >= 1.19.3for the build environmentshapely <= 2.0.1for the runtime environment (for me the compile errors started with that patch)For Python > 3.9:
oldest-supported-numpyfor the build environmentshapelyfor the runtime environmentThis seems to work but I am not sure I understand the ramifications of the build requirements and wheter
oldest-supported-numpyis deprecated now, so feedback welcome.