Fix WELTRAJ/COMPTRAJ keyword handling #4279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
bska
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
I'm on the fence about this. On the one hand, the code is fine and the tests are good. On the other hand, the simulator really should not depend on MAPAXES since that's purely a convenience for post-processors like ResInsight and others. That said, I do see the utility in being able to specify coordinates in terms of a survey map and given that this feature isn't necessary to run the simulator I'm going to merge it into the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WELTRAJ and COMPTRAJ keywords were added some time ago to enable specification of trajectory wells. This PR fixed a few issues:
The existing test case had its origin at zero, and a linear trajectory, which does not test the fixes. Therefore a new test case is added that has its origin at non-zero, and a non-linear trajectory. I see value in keeping the old simple test case together with the new test case, but it could be argued that the simple case could be removed. Feedback on that is welcome.