Writing THCONR to INIT #4474
Writing THCONR to INIT #4474
Conversation
|
Jenkins build this please |
bska
left a comment
There was a problem hiding this comment.
The feature here is probably okay, but the changes to the UnitSystem must be accompanied by a comprehensive set of unit tests to verify that the conversions produce the expected results.
opm/input/eclipse/Units/Units.hpp
Outdated
| constexpr const double Moles = kilo*pound*mol; | ||
| constexpr const double PPM = ppm; | ||
| constexpr const double Ymodule = giga*Pascal; | ||
| constexpr const double ThermalConductivity = btu/(degFahrenheit*day*centi*meter); |
There was a problem hiding this comment.
I would normally expect feet as a basic length unit instead of centi*meter in FIELD units.
There was a problem hiding this comment.
Thanks for noticing, when doing this I looked up back and on line 320 for surface tension is used centi*meter, then I will also change that to feet.
There was a problem hiding this comment.
320 for surface tension is used centi*meter, then I will also change that to feet.
Please don't. Surface tension is dyne/cm in all unit systems.
There was a problem hiding this comment.
Ok, I have added tests for the unit conversion as requested, please let me know if further changes are needed before merging this.
|
Jenkins build this please |
|
jenkins build this update_data please |
Reason: PR OPM/opm-common#4474 opm-common = e82641b6c75ccdaf551bdf56d5c408795fdf28db opm-grid = c0d2beb91e114081d373da40fc1c2c0d41eeccfd opm-simulators = e82641b6c75ccdaf551bdf56d5c408795fdf28db ### Changed Tests ### * spe1_thermal * spe1_thermal_watvisc * spe1_thermal_onephase * co2store_energy * h2store_energy
|
jenkins build this opm-tests=1290 please |
Automatic Reference Data Update for PR OPM/opm-common#4474
bska
left a comment
There was a problem hiding this comment.
Thanks a lot for the updates. This looks good to me now and as the updated reference solutions have been installed on the CI system I'll merge into master.
Writing THCONR to INIT