Activate WELPI and WPIMULT for use in Pyaction #4434
Conversation
|
jenkins build this opm-simulators=5892 please |
|
I'm out of the office until Monday so I can't review this before then. That said, I really appreciate you taking the time to explore this alternative! |
e49b10e to
359cdc5
Compare
|
jenkins build this opm-simulators=5892 please |
No worries, I liked your idea and I'm looking forward to your feedback when you're back 🙂! |
359cdc5 to
40d1a92
Compare
|
jenkins build this opm-simulators=5892 please |
40d1a92 to
11c54ff
Compare
|
jenkins build this opm-simulators=5892 please |
11c54ff to
b50e897
Compare
|
jenkins build this opm-simulators=5892 please |
b50e897 to
160072e
Compare
|
jenkins build this opm-simulators=5892 please |
160072e to
3636592
Compare
|
jenkins build this opm-simulators=5892 please |
3636592 to
080043c
Compare
|
jenkins build this opm-simulators=5892 please |
There was a problem hiding this comment.
Thanks a lot for making this alternative implementation. This looks really good. Other than the renaming of the HandlerContext data member I have no notes. If you would like revert back to the original name–or something else that's not quite as tightly associated to WELPI–then feel free to do so now. Otherwise, I'm in favour of merging this as is with a possible caveat that I may follow up with a renaming PR later.
I'll review the downstream PR now.
…hedule and the run functions of PyAction and PyRunModule. The argument is the analogon to the argument target_wellpi of applyAction for an ActionX. Also, the target_wellpi map is an attribute of opm_embedded module object. With this, it is possible to communicate old well production indices from the ActionHandler (i.e. the Well Model) back to the applyKeywords funcion of the Schedule. The old well production indices are needed when a user inserts the keyword WELPI or WPIMULT from a python script using the PyAction functionality.
…or ActionX but also for Pyaction
…bute of opm_embedded as well
080043c to
7d5ba9a
Compare
|
jenkins build this opm-simulators=5892 please |
Alternative to #4136 as suggested by @bska in #4136 (comment)
For the reference manual: With this PR and OPM/opm-simulators#5892, the keywords WELPI and WPIMULT can be used in the "insert keywords"-function in Pyaction.