Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bska
Copy link
Member

@bska bska commented Jan 21, 2025

If the base run sets these, and the restarted run does not, then we would reset them to their default values in the restarted run.

If the base run sets these, and the restarted run does not, then we
would reset them to their default values in the restarted run.
@bska
Copy link
Member Author

bska commented Jan 21, 2025

Note: Other than when creating the restart file, these values aren't actually used anywhere–as exemplified by WSEGITER being marked as 'unsupported' at the simulator level. However, if we're ever going to have restart-type integration tests for models using WSEGITER, then not reloading these items would generate a "false negative" test failure.

@bska
Copy link
Member Author

bska commented Jan 21, 2025

jenkins build this please

Copy link
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to realize that the big hunk wasn't really the change. Looks fine.

@bska
Copy link
Member Author

bska commented Jan 21, 2025

Took me a while to realize that the big hunk wasn't really the change

Sorry about that. That really should have been a separate commit.

Looks fine.

Thanks. As the PR's approved and the build check is green I'll merge into master.

@bska bska merged commit a6fffdc into OPM:master Jan 21, 2025
1 check passed
@bska bska deleted the load-msw-iter-params-for-restart branch January 21, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants