Fix for including a file with an incorrectly terminated keyword #4563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
jenkins build this please |
Author
|
@blattms: Can you have a look here, please? Thanks! |
blattms
reviewed
Apr 10, 2025
17cf5a3 to
6d3be35
Compare
blattms
approved these changes
Apr 11, 2025
Member
|
Marked this for the release as there is no way a user can guess what is wrong without it. |
Member
|
Very good, I will backport this for RC3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the include in the test added in the last commit of this PR resulted in a segmentation fault (see the failing test in #4564) because a keyword in the included file was terminated incorrectly. Now a proper error message is shown, pointing to that keyword.
This closes issue #4473.