Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rouault
Copy link
Member

@rouault rouault commented Mar 14, 2024

Backport of second commit of #4085

@rouault rouault added this to the 9.4.1 milestone Mar 14, 2024
@rouault
Copy link
Member Author

rouault commented Mar 16, 2024

The slight doubt I had about the appropriateness of the backport is that the WGS84 datum ensemble has gained a new datum realization with "World Geodetic System 1984 (G2296)", which thus changes the WKT2:2019 output of all EPSG:4326 based CRS. This could potentially break code (particular unit tests) that would do strict text comparison. But as far as GDAL is concerned, I didn't have tou change any unit tests (perhaps we already bit that bullet in the past with prior additions of new realizations so our tests are now robust to that)
Furthermore the isEquivalentTo() method considers CRS WKT definitions that only differ by differences in members of datum ensembles to be the same. And the identify() method also works with slightly different members in a datum ensemble provided it has the same name
So all in all, I believe it is reasonably safe for backport to stable branch.
CC @jjimenezshaw @kbevers

Copy link
Member

@kbevers kbevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to backport this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants