CRS::stripVerticalComponent(): Redirect it to demoteTo2D(std::string(), nullptr) #4127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d974873 to
6fdef27
Compare
6fdef27 to
1ab7c44
Compare
jjimenezshaw
approved these changes
Apr 26, 2024
…), nullptr) stripVerticalComponent() was implemented in the initial commit of the PROJ 6 / GDAL Barn SRS effort, but was not used internally at that time. Just as a potential useful method for future users Later we needed promoteTo3D(), and soon after the reverse operation, but we (likely) forgot about the existence of stripVerticalComponent(). Hence a new demoteTo2D() method, which is more capable than the initial stripVerticalComponent().
1ab7c44 to
d3cb3fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripVerticalComponent() was implemented in the initial commit of the PROJ 6 / GDAL Barn SRS effort, but was not used internally at that time. Just as a potential useful method for future users
Later we needed promoteTo3D(), and soon after the reverse operation, but we (likely) forgot about the existence of stripVerticalComponent(). Hence a new demoteTo2D() method, which is more capable than the initial stripVerticalComponent().