-
Notifications
You must be signed in to change notification settings - Fork 858
Database: add a engineering_datum and engineering_crs tables; import few related EPSG records #4396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I didn't know that EPSG contained some engineering CRSs (it doesn't make so much sense to me, but that doesn't matter). I hope people do not start adding their own engineering CRSs, because that could definitely exhaust the IDs. Will these new systems appear in the lists, either from |
yes, $ PROJ_DATA=data bin/projinfo --list-crs | grep Christma
I was thinking more of that being useful for a custom authority where people define their custom engineering CRS and a transformation to a more "standard" one. |
1ba4008 to
a6434e9
Compare
That sounds like the derived projected I did some time ago, but in the database, not as wkt ;) |
|
@ other maintainers: good idea / bad idea ? |
Could you elaborate a bit on the idea? I'm not sure I understand it. Is this a proposal to put the already included EPSG EngineeringCRS's under new authority? Or a mechanism for users to that themselves instead of going to the trouble of submitting stuff to the EPSG? If it's the last one, what would that look like? |
|
|
That sounds like a description of this PR. I don't think any of it is controversial and can in my opinion be merged as is. I was under the impression you were referring to a different idea, as hinted at by
but I must have misread that. |
|
Just curiosity: do all the engineering systems in EPSG have a transformation associated? |
apparently not. On the 15 added, only 3 have a transformation to a projected CRS. |
|
My initial surprise was that EPSG had engineering systems in the database. For me an engineering system is the opposite of what EPSG is for. But it is there. If we want to replicate the structure of EPSG, it is ok to include them. The use case of users customizing their database to add their own engineering systems, ok. And better if they add a transformation to a "proper" one (and we support that). |
I wouldn't bet my hand that it works for all transformations (as some of them might have expectations on the nature of the source/target CRS), but at least it works with "Cartesian Grid Offsets" and "Similarity transformation". |
…few related EPSG records
a6434e9 to
bfd48ce
Compare
No description provided.