Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantially improved and revamped credential pattern matching (See testing/regex_testing/test_cases.txt for a comprehensive set of examples for all pattern matching enhancements listed in this update)
Password: notquotedvalue(we already support password followed by equal sign... this was just for colon without quotes)${variable},#{variable},%%variable%%, etc..)$will not be flagged unless an additional numeric or special character is included in the value:myPwd = $uperStr0ngwill be flagged, butmyPwd = $passwordwill not be flagged as it is assumed a variable (known limitation: we do not yet process regexes based on file extension)${},#{}, or{}are assumed variables and will not be flagged even if they contain a numeric value i.e.apiKey = $S3_APIKEYwill be flagged, butapiKey = ${S3_APIKEY}will not be flagged%%environment variables i.e.<Password>%%variable%%</Password>is considered a variableUpdated SEDATED® references from ℠ to ®