Improvements in user profile (Issue #128) #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @AHarmlessPyro , can you please add screenshot for this in PR description? |
Contributor
Author
|
Here you go @JBAhire Can't use a screenshot since cursor doesn't seem to be captured in mac os. This shows the highlight ring around the profile avatar along with the different cursor. I've tried to mimic the visual behavior of facebook a bit here since that works well while still keeping the clickable area limited to the avatar itself. |
Collaborator
|
This looks good to me, @AHarmlessPyro ! Thanks for putting this together. @piyushroshan , please review. |
piyushroshan
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refer to Issue #128
Some users feel that the User Profile can be improved. It is not clear to everyone that you can click on the profile photo to update account info.Have added a
pointerstyle cursor to profile. In addition, nested the profile avatar inside a container that highlights to a color (#1890ff, as used in other button style elements in UI).Testing
Has been tested manually.
Documentation
N.A.
Checklist: