Incorrect Login Credentials Unhandled Exception #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
Along with try catch we should also add an if block for the null scenario of JWT token.
Collaborator
Author
There was a problem hiding this comment.
The if block checking for the null condition of the JWT token is part of the try block.
piyushroshan
approved these changes
May 27, 2022
piyushroshan
requested changes
May 27, 2022
Collaborator
piyushroshan
left a comment
There was a problem hiding this comment.
Add unit test for this
1f6e0de to
b8bf01b
Compare
b8bf01b to
19ca7f2
Compare
piyushroshan
approved these changes
May 28, 2022
piyushroshan
added a commit
that referenced
this pull request
Jan 19, 2026
Incorrect Login Credentials Unhandled Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull request to fix #55. An incorrect login attempt will now result in a response of
401.Testing
Tested with incorrect email ID and an incorrect password and verified the return status code.
Checklist: