use numbered dataflow labels on seq diagram #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
nineinchnick
commented
Mar 26, 2020
81adc61 to
20a7442
Compare
16f7410 to
2b239d9
Compare
6fa1914 to
f2b70df
Compare
f2b70df to
19eef7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use numbered dataflow labels on seq diagram. This makes it easier to read when comparing seq and dfd diagrams.
Please note that changes here are very similar to what's proposed in #80, that is:
Elementclasswhich makes it even easier to override classes. As a side effect,
_dfd()method has been removed from most classes since it's a duplicate now.This also has the same fix as #93 but that other PR is way simpler and might be merged earlier.
Preview:
