handle duplicate dataflows #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94dc74a to
8d325c3
Compare
8d325c3 to
a716899
Compare
izar
approved these changes
May 19, 2020
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some models might have multiple Dataflows between same source and sink that have all same properties (except name and note). They may be required if using the sequence diagram to make it complete but drawing them on the DFD makes it less readable.
This MR adds a new property called
TM.onDuplicateswith three possible values. By default, no action is taken. When set toRESTRICT, an exception is raised when such dataflows are found. This is meant for models not using the sequence diagram. When set toIGNORE, duplicates are allowed but are not drawn on DFD, only on the sequence diagram.