Fix: Increased the character limit from 140 to 280 and added a delete button on launch control. #4105

rinkitadhana · 2025-04-05T18:39:58Z

Description:

Increased the character limit from 140 to 280 and added a delete button on launch control.

Summary by CodeRabbit

New Features
- Increased the message character limit from 140 to 280 across the application, including Twitter-related functionalities.
- Updated message input interfaces and error notifications to display the new 280-character limit.
- Added a new action option on the queue view for easier deletion of items.

coderabbitai · 2025-04-05T18:40:07Z

Walkthrough

The pull request updates the character limit for messages across the application from 140 to 280 characters. A new migration file has been added to alter the queue model’s message field, and corresponding changes were made in the models, templates, and views. The models file now reflects the updated Twitter message handling, while the templates and views have been adjusted to enforce the new character limit and update related UI elements and validations.

Changes

File(s)	Change Summary
website/migrations/0236_alter_queue_message.py	New migration file modifying the `queue.message` field to use a `CharField` with a max_length of 280 and updated help text.
website/models.py	Updated `TWITTER_MAXLENGTH` from 140 to 280; modified `get_twitter_message` logic to support 280 characters; updated `Queue.message` field to 280 characters with revised help text.
website/templates/queue/list.html	Increased maxlength in form textareas from 140 to 280; updated label text and character count display; added a new "Actions" column with a delete button for each queue item.
website/views/queue.py	Modified validation in the `queue_list` function to check against a 280-character limit and updated the corresponding error messages accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant Q as Queue View
    U->>Q: Submit Queue Item Form with message
    alt Message length > 280
        Q->>U: Return error message ("Message cannot exceed 280 characters")
        Q->>U: Redirect to Queue List
    else Valid message
        Q->>Q: Process and store queue item
        Q->>U: Redirect to Queue List
    end

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd58efb and 1d46bfd.

📒 Files selected for processing (4)

website/migrations/0236_alter_queue_message.py (1 hunks)
website/models.py (3 hunks)
website/templates/queue/list.html (4 hunks)
website/views/queue.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Run Tests
GitHub Check: docker-test

🔇 Additional comments (13)

website/migrations/0236_alter_queue_message.py (1)

1-18: Well-structured migration for increasing character limit.

This migration appropriately updates the message field in the queue model to increase the character limit from 140 to 280 characters, with the help text also updated to reflect this change. This aligns with the PR's objective of increasing the character limit.

website/templates/queue/list.html (8)

183-183: Updated character limit in label text.

The label now correctly shows the new 280 character limit for messages in the Create New Queue Item form.

189-189: Updated HTML attribute for maximum character limit.

The maxlength attribute has been properly increased to 280 characters to enforce the new limit on the client side.

192-192: Updated character counter display.

The counter display now correctly shows the limit as 280 characters to match the new maximum.

264-264: Updated character limit in edit form label.

Label in the Edit Queue Item form correctly shows the new 280 character limit.

270-270: Updated edit form textarea maxlength.

The maxlength attribute in the edit form has been properly increased to 280.

273-273: Updated edit form character counter.

Character counter in the edit form now correctly shows "/280" to match the new limit.

514-517: Added "Actions" column to launched items table.

A new column for "Actions" has been added to the table header in the Recently Launched Items section to accommodate the new delete functionality.

588-595: Added delete button implementation for launched items.

This code adds a delete button to each launched item row, allowing users to delete items from the launch control section. The form includes the necessary CSRF token, action value "delete", and the item's queue_id. This implements the second part of the PR objective - adding a delete button on launch control.

website/views/queue.py (2)

39-41: Updated character limit validation for message creation.

The message length validation for the create operation has been properly updated to reflect the new 280 character limit, along with the corresponding error message.

61-63: Updated character limit validation for message editing.

The message length validation for the edit operation has been properly updated to reflect the new 280 character limit, along with the corresponding error message.

website/models.py (2)

636-636: Updated Twitter maximum length constant.

The TWITTER_MAXLENGTH constant has been updated to 280, which aligns with Twitter's current character limit.

2359-2359: Updated message field in Queue model.

The message field in the Queue model has been updated to have a maximum length of 280 characters, with the help text also reflecting this change. This ensures database-level validation of the new character limit.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sentry · 2025-04-05T18:40:11Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/views/queue.py

Function	Unhandled Issue
`queue_list`	NotImplementedError: This backend doesn't support absolute paths. ... `Event Count:` 7

_{Did you find this useful? React with a 👍 or 👎}

rinkitadhana added 2 commits April 5, 2025 20:43

char limit increased from 140 to 280

1278a3c

delete button added on the launch control

a51416c

Merge branch 'main' into fix/ch-queue

1d46bfd

DonnieBLT approved these changes Apr 5, 2025

View reviewed changes

DonnieBLT linked an issue Apr 5, 2025 that may be closed by this pull request

replace the /social code with the content from the queue model, show it in a list with a link to the url and image #3996

Closed

coderabbitai bot approved these changes Apr 5, 2025

View reviewed changes

DonnieBLT added this pull request to the merge queue Apr 7, 2025

Merged via the queue into OWASP-BLT:main with commit ec1013f Apr 7, 2025
11 of 12 checks passed

rinkitadhana deleted the fix/ch-queue branch April 7, 2025 20:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix: Increased the character limit from 140 to 280 and added a delete button on launch control. #4105

Fix: Increased the character limit from 140 to 280 and added a delete button on launch control. #4105

Uh oh!

rinkitadhana commented Apr 5, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 5, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

sentry bot commented Apr 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Fix: Increased the character limit from 140 to 280 and added a delete button on launch control. #4105

Fix: Increased the character limit from 140 to 280 and added a delete button on launch control. #4105

Uh oh!

Conversation

rinkitadhana commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

sentry bot commented Apr 5, 2025

🔍 Existing Issues For Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rinkitadhana commented Apr 5, 2025 •

edited

Loading

coderabbitai bot commented Apr 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)