fixes bounties/payouts #4171

Nitish-Naik · 2025-04-24T15:53:38Z

Modified post function to fetch all pages of GitHub issues with pagination.
Fixes issue where not all bounties were shown on /bounties/payouts/ page as reported in #4031.
Fixes: #4031

Summary by CodeRabbit

New Features
- Improved retrieval of closed GitHub issues with bounties by fetching all available pages, ensuring a complete and up-to-date list.
Bug Fixes
- Enhanced error handling for GitHub API responses to provide more reliable results when issues cannot be fetched.

coderabbitai · 2025-04-24T15:53:45Z

"""

Walkthrough

The changes modify the BountyPayoutsView class in website/views/organization.py to enhance how GitHub issues with bounties are retrieved and processed. The github_issues_with_bounties method now returns both the list of issues and the total count, extracted from the GitHub API response. The post method is updated to implement pagination, looping through all pages of closed issues labeled "$5" until all are fetched. Error handling is adjusted to return an empty list and zero count on failure. A redundant commented-out line related to pull request filtering is removed.

Changes

File(s)	Change Summary
website/views/organization.py	Updated `github_issues_with_bounties` to return a tuple (issues, total_count). Modified `post` to implement pagination for fetching all relevant GitHub issues. Improved error handling and removed an obsolete comment.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BountyPayoutsView
    participant GitHubAPI

    User->>BountyPayoutsView: POST request
    loop For each page of issues
        BountyPayoutsView->>GitHubAPI: Fetch closed issues with "$5" label (page N)
        GitHubAPI-->>BountyPayoutsView: Return issues list and total_count
        BountyPayoutsView->>BountyPayoutsView: Accumulate issues, check if done
    end
    BountyPayoutsView-->>User: Return accumulated issues

"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 344c591 and 572906b.

📒 Files selected for processing (1)

website/views/organization.py (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

website/views/organization.py

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Run Tests
GitHub Check: docker-test
GitHub Check: Analyze (python)
GitHub Check: Analyze (javascript-typescript)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef61911 and 99a7337.

📒 Files selected for processing (1)

website/views/organization.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Run Tests
GitHub Check: Analyze (python)
GitHub Check: docker-test
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (2)

website/views/organization.py (2)

2739-2750: Good improvement to return total count for pagination support.

This change enhances the github_issues_with_bounties method to return both the list of issues and the total count from the GitHub API response, which is necessary for implementing proper pagination.

2769-2783: Excellent implementation of pagination for GitHub issues.

This change fixes the core issue by implementing pagination to fetch all GitHub issues with bounties. The code now iteratively fetches issues page by page until either all issues are retrieved or no more pages remain.

website/views/organization.py

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

fixes bounties/payouts

99a7337

coderabbitai bot requested changes Apr 24, 2025

View reviewed changes

website/views/organization.py Outdated Show resolved Hide resolved

Update website/views/organization.py

344c591

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai bot previously approved these changes May 3, 2025

View reviewed changes

Update organization.py

572906b

DonnieBLT dismissed coderabbitai[bot]’s stale review via 572906b May 3, 2025 00:54

DonnieBLT enabled auto-merge May 3, 2025 00:55

DonnieBLT approved these changes May 3, 2025

View reviewed changes

coderabbitai bot approved these changes May 3, 2025

View reviewed changes

DonnieBLT added this pull request to the merge queue May 3, 2025

Merged via the queue into OWASP-BLT:main with commit 1b5f5ec May 3, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fixes bounties/payouts #4171

fixes bounties/payouts #4171

Uh oh!

Nitish-Naik commented Apr 24, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 24, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fixes bounties/payouts #4171

fixes bounties/payouts #4171

Uh oh!

Conversation

Nitish-Naik commented Apr 24, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Nitish-Naik commented Apr 24, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)