-
-
Notifications
You must be signed in to change notification settings - Fork 313
Fix: Hackathon timezone #4208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Hackathon timezone #4208
Conversation
WalkthroughThe hackathon detail page template was updated to display the timezone abbreviation alongside the start and end times in the timeline section by adjusting the date formatting string. Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
website/templates/hackathons/detail.html (1)
100-104: Optional enhancement: Render times in hackathon‐specific timezone
If yourhackathonmodel includes its own timezone field (e.g.hackathon.timezone), you may want to convert the timestamps into that zone before formatting. For example:{{ hackathon.start_time|timezone:hackathon.timezone|date:"F j, Y, g:i a T" }} {{ hackathon.end_time |timezone:hackathon.timezone|date:"F j, Y, g:i a T" }}This guarantees the displayed times and abbreviations align with the event’s official timezone rather than the server’s or user’s default.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
website/templates/hackathons/detail.html(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Run Tests
- GitHub Check: docker-test
🔇 Additional comments (2)
website/templates/hackathons/detail.html (2)
100-100: Display timezone abbreviation for start time
IncludingTin the date filter will append the timezone abbreviation (e.g.UTC,EST) after the AM/PM indicator for the hackathon start time, improving clarity in the timeline.
104-104: Display timezone abbreviation for end time
Likewise, addingTto the date filter ensures the timezone abbreviation is shown for the hackathon end time, matching the start time format.
Summary by CodeRabbit