BACON/sol-bacon/metadata.json (1)

1-6: Token metadata looks good, but consider specifying the token standard

The metadata JSON structure is valid and includes the essential fields (name, symbol, description, image) with the IPFS link correctly formatted. The use of Pinata for IPFS hosting is a good practice for decentralized storage.

Consider adding:

1. Documentation about which Solana token standard this metadata follows (e.g., SPL Token, Metaplex NFT)
2. Additional optional fields like "decimals" if this is an SPL token

BACON/sol-bacon/setup-solana-bacon.sh (3)

3-4: Customize the default token name

The TOKEN_NAME variable is currently set to "your-token-name" which appears to be a placeholder. Consider setting it to "bacon" or "sol-bacon" to align with the project name and metadata file.

- TOKEN_NAME="your-token-name"
+ TOKEN_NAME="sol-bacon"

---

13-50: Consider Docker security best practices in the Dockerfile

The Dockerfile follows a decent structure but could benefit from these improvements:

1. Running as a non-root user for better security
2. Using multi-stage builds to reduce image size
3. Setting a specific version for Rust and Solana CLI instead of using the latest version for predictable builds
4. Adding HEALTHCHECK instruction to verify the container is working properly

Here's a sample improvement:

 # Use a lightweight base image
 FROM debian:bullseye-slim
 
 # Set non-interactive frontend for apt
 ENV DEBIAN_FRONTEND=noninteractive
 
 # Install required dependencies and Rust
 RUN apt-get update && apt-get install -y \
     curl build-essential libssl-dev pkg-config nano \
     && curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y \
     && apt-get clean && rm -rf /var/lib/apt/lists/*
 
 # Add Rust to PATH
 ENV PATH="/root/.cargo/bin:$PATH"
 
 # Verify Rust installation
 RUN rustc --version
 
 # Install Solana CLI
 RUN curl -sSfL https://release.anza.xyz/stable/install | sh \
     && echo 'export PATH="$HOME/.local/share/solana/install/active_release/bin:$PATH"' >> ~/.bashrc
 
 # Add Solana CLI to PATH
 ENV PATH="/root/.local/share/solana/install/active_release/bin:$PATH"
 
 # Verify Solana CLI installation
 RUN solana --version
 
 # Set up Solana config for Devnet
 RUN solana config set -ud
 
 # Set working directory
 WORKDIR /solana-token
 
+# Create non-root user
+RUN useradd -m solanauser
+USER solanauser
+
 # Default command to run a shell
 CMD ["/bin/bash"]

---

52-59: Enhance Docker build and run commands with better practices

The Docker build and run commands could benefit from:

1. Using the TOKEN_NAME variable in the image tag for consistency
2. Adding error handling to verify Docker commands complete successfully
3. Adding container labels for better identification
4. Setting resource limits

 # Build Docker image
-docker build -t heysolana .
+docker build -t "solana-${TOKEN_NAME}" \
+  --label "project=${TOKEN_NAME}" \
+  --label "version=1.0" \
+  . || { echo "Docker build failed"; exit 1; }
 
 # Run Docker container interactively
 docker run -it --rm \
   -v "$(pwd)":/solana-token \
   -v "$(pwd)/solana-data":/root/.config/solana \
-  heysolana
+  --name "solana-${TOKEN_NAME}-container" \
+  --memory="2g" \
+  --cpus="2" \
+  "solana-${TOKEN_NAME}" || { echo "Docker run failed"; exit 1; }

BACON/ord-server/ord-api.py (1)

1-7: Consider adding proper docstrings and input validation

The file lacks proper documentation and doesn't implement robust input validation.

Add descriptive docstrings and implement a validation helper function:

 import os
 import subprocess
 
 import yaml
 from dotenv import load_dotenv
 from flask import Flask, jsonify, request
+from marshmallow import Schema, fields, validate, ValidationError
+
+"""
+Flask API for sending bacon tokens on Bitcoin networks using the Ordinal protocol.
+
+This API provides endpoints for sending tokens on both mainnet and regtest networks.
+It uses the ord binary to perform wallet split operations with batch transactions.
+"""
+
+class MainnetTokenRequestSchema(Schema):
+    """Schema for validating mainnet token requests."""
+    yaml_content = fields.String(required=True)
+    fee_rate = fields.Float(required=True, validate=validate.Range(min=1.0))
+    dry_run = fields.Boolean(missing=False)
+
+class RegtestTokenRequestSchema(Schema):
+    """Schema for validating regtest token requests."""
+    num_users = fields.Integer(required=True, validate=validate.Range(min=1, max=100))
+    fee_rate = fields.Float(required=True, validate=validate.Range(min=1.0))
+
+def validate_request(schema_class):
+    """Decorator for validating request data against a schema."""
+    def decorator(func):
+        def wrapper(*args, **kwargs):
+            schema = schema_class()
+            try:
+                validated_data = schema.load(request.json)
+                return func(validated_data, *args, **kwargs)
+            except ValidationError as err:
+                return jsonify({"success": False, "error": err.messages}), 400
+        wrapper.__name__ = func.__name__
+        return wrapper
+    return decorator

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting