Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Copy link
Contributor

Copilot AI commented May 21, 2025

This PR implements a notification system to alert both the BLT team (admin users) and issue reporters when payments are processed. The goal is to improve transparency and keep all stakeholders informed about payment transactions.

Implementation Details

  1. Added a new signal handler in notification_signals.py:

    • Creates notifications when payments are recorded on GitHubIssue objects
    • Sends notifications to:
      • The issue reporter who submitted the bug
      • All admin users (except the one who processed the payment)
    • Includes payment details such as transaction ID and payment method
  2. Updated payment processing logic in organization.py:

    • Added a reference to the notification system in the success message
    • Ensured users know that notifications are being sent
  3. Added safeguards for notification creation:

    • Checks for duplicate notifications to prevent spamming
    • Verifies payment information is present before sending notifications
    • Adds detailed logging for easier debugging and verification

Example Notifications

For issue reporters:

Your bounty for issue #123 has been paid via GitHub Sponsors. Transaction ID: ch_abc123xyz

For admin team:

Payment processed for issue #123 via Bitcoin Cash. Transaction ID: abcdef123... (by admin_username)

Testing

The implementation was reviewed carefully to ensure it integrates well with the existing notification and payment systems. The signal handler listens for changes to payment-related fields and only triggers when a payment is actually processed.

Fixes #1916.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.fwupd.org
    • Triggering command: /usr/bin/fwupdmgr refresh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Payment Notifications: Implement a notification system to alert the BLT team and users when a payment is processed, ensuring transparency and keeping users informed about their transactions. Implement payment notification system for BLT team and users May 21, 2025
Copilot AI requested a review from DonnieBLT May 21, 2025 15:25
@github-actions github-actions bot added the files-changed: 2 PR changes 2 files label May 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 21, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the unresolved-conversations: 0 PR has 0 unresolved conversations label Nov 16, 2025
@github-actions
Copy link
Contributor

❌ Pre-commit checks failed

The pre-commit hooks found issues that need to be fixed. Please run the following commands locally to fix them:

# Install pre-commit if you haven't already
pip install pre-commit

# Run pre-commit on all files
pre-commit run --all-files

# Or run pre-commit on staged files only
pre-commit run

After running these commands, the pre-commit hooks will automatically fix most issues.
Please review the changes, commit them, and push to your branch.

💡 Tip: You can set up pre-commit to run automatically on every commit by running:

pre-commit install

For more information, see the pre-commit documentation.

@DonnieBLT DonnieBLT marked this pull request as ready for review November 16, 2025 22:26
@github-actions
Copy link
Contributor

❌ Pre-commit checks failed

The pre-commit hooks found issues that need to be fixed. Please run the following commands locally to fix them:

# Install pre-commit if you haven't already
pip install pre-commit

# Run pre-commit on all files
pre-commit run --all-files

# Or run pre-commit on staged files only
pre-commit run

After running these commands, the pre-commit hooks will automatically fix most issues.
Please review the changes, commit them, and push to your branch.

💡 Tip: You can set up pre-commit to run automatically on every commit by running:

pre-commit install
Pre-commit output
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/pycqa/isort.
[WARNING] repo `https://github.com/pycqa/isort` uses deprecated stage names (commit, merge-commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pycqa/isort` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/astral-sh/ruff-pre-commit.
[INFO] Initializing environment for https://github.com/djlint/djLint.
[INFO] Initializing environment for local.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/astral-sh/ruff-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/djlint/djLint.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check python ast.........................................................Passed
check builtin type constructor use.......................................Passed
check yaml...............................................................Passed
fix python encoding pragma...............................................Passed
mixed line ending........................................................Passed
isort....................................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Failed
- hook id: ruff-format
- files were modified by this hook

2 files reformatted, 427 files left unchanged


For more information, see the pre-commit documentation.

@github-actions github-actions bot added the pre-commit: passed Pre-commit checks passed label Nov 16, 2025
@DonnieBLT DonnieBLT merged commit 0efaf61 into main Nov 16, 2025
17 checks passed
@DonnieBLT DonnieBLT deleted the copilot/fix-1916 branch November 16, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

files-changed: 2 PR changes 2 files pre-commit: passed Pre-commit checks passed unresolved-conversations: 0 PR has 0 unresolved conversations

Projects

Status: Done

2 participants