-
-
Notifications
You must be signed in to change notification settings - Fork 313
Implement new GitHub login page #4479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds two new Django templates: Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Browser
participant Django as Django App
participant Social as SocialAuth View
participant GitHub
rect rgb(240,248,255)
User->>Browser: Open "Connect GitHub" page
Browser->>Django: GET /socialaccount/login/ (renders template)
Django-->>Browser: HTML (socialaccount/login.html)
end
rect rgb(245,255,240)
Browser->>Django: POST /socialaccount/login/ (form submit, CSRF token)
Django->>Social: Hand off to social auth flow
Social->>GitHub: Redirect to GitHub OAuth
GitHub-->>Social: OAuth callback
Social-->>Django: Authenticate / link account
Django-->>Browser: Redirect to next page / show status
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Knowledge base: Disabled due to 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
951f386 to
b683d8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements a new GitHub login page with modern UI design, replacing a basic static version. The redesign includes improved styling using Tailwind CSS, proper localization support, and a more polished user experience.
- Added complete HTML template for GitHub social account login
- Implemented responsive design with modern card-based layout
- Integrated GitHub branding with SVG icon and proper color scheme
| <svg class="w-12 h-12 text-gray-800" viewBox="0 0 16 16" version="1.1"> | ||
| <path fill="currentColor" d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0016 8c0-4.42-3.58-8-8-8z"> |
Copilot
AI
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub icon color should use the project's red color #e74c3c instead of text-gray-800 to maintain brand consistency throughout the login page.
|
@razzasid we would rather override the style in the allauth base template so it applies to all templates |
DonnieBLT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please override the one file base template in allauth so it applies to all allauth pages.
5e9641b to
ef94509
Compare
ef94509 to
0d475f0
Compare
|
Hi @DonnieBLT I've implemented the styling feedback. The allauth base template ( |
Redesigned the GitHub login page with improved UI styling and layout, replacing the previous basic static version for a more polished and user-friendly look.
--- before ---

--- after ---

Summary by CodeRabbit