website/views/project.py (1)

1898-1985: Consider extracting common badge generation logic.

The badge generation code in RepoBadgeView is nearly identical to ProjectBadgeView (lines 169-253). Both classes implement the same chart rendering logic with only minor differences (project vs. repo objects).

Consider extracting the common badge generation logic into a shared helper method or base class to improve maintainability and reduce duplication. This would make future updates (like color schemes or layout changes) easier to apply consistently.

Example approach:

• Create a _generate_badge_image helper method that accepts visit data and total count
• Both view classes call this helper with their respective data
• Reduces ~100 lines of duplicated code

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

website/views/project.py (3)

122-265: Consider extracting common badge generation logic.

Both ProjectBadgeView and RepoBadgeView contain nearly identical code (~140 lines each) with only minor differences (model type and field names). This duplication violates the DRY principle and creates maintenance burden.

Consider extracting the common badge generation logic into a helper function or base class:

class BaseBadgeView(APIView):
    """Base class for generating visit badges."""
    
    model_class = None  # Override in subclass
    count_field = None  # Override in subclass
    
    def get_client_ip(self, request):
        # ... (current implementation) ...
    
    def generate_badge(self, obj, request):
        # ... (common badge generation logic) ...
    
    def get(self, request, slug):
        obj = get_object_or_404(self.model_class, slug=slug)
        # ... (IP tracking logic) ...
        return self.generate_badge(obj, request)

class ProjectBadgeView(BaseBadgeView):
    """Generates a 30-day unique visits badge PNG for a Project."""
    model_class = Project
    count_field = 'project_visit_count'

class RepoBadgeView(BaseBadgeView):
    """Generates a 30-day unique visits badge PNG for a Repo."""
    model_class = Repo
    count_field = 'repo_visit_count'

This refactor would eliminate duplication, reduce the risk of divergence, and simplify future maintenance.

Also applies to: 1850-1998

---

145-145: Clarify or remove unclear comment.

The comment "(original case-sensitive lookup)" is unclear. It doesn't explain why this is noted or what alternative was considered. If case-sensitivity was intentionally preserved, consider clarifying why; otherwise, remove the comment.

---

206-221: Consider extracting magic numbers as constants.

Several hardcoded values reduce code maintainability:

• 28 (font size)
• 15 (text y position)
• 50 (text height)
• 40 (margin)
• 32, 30 (bar calculations)

Consider extracting these as class-level constants:

class ProjectBadgeView(APIView):
    # Badge dimensions
    BADGE_WIDTH = 600
    BADGE_HEIGHT = 200
    MARGIN = 40
    TEXT_HEIGHT = 50
    FONT_SIZE = 28
    TEXT_Y_POSITION = 15
    
    # Bar calculations
    BAR_COUNT = 30
    BAR_WIDTH_DIVISOR = 32  # 30 bars + 2 for margins
    
    # Colors
    BAR_COLOR = "#e05d44"
    FAINT_COLOR = "#fcbab3"
    GRID_COLOR = "#eeeeee"

This would make the code more maintainable and self-documenting.

Also applies to: 1936-1951

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

website/views/project.py (1)

196-265: Consider extracting shared chart rendering logic to reduce duplication.

The chart rendering logic (lines 196-265 and 1926-1998) is nearly identical between ProjectBadgeView and RepoBadgeView, with only minor differences in the visit count field accessed. Consider extracting a shared helper function (e.g., build_badge_image(dates, counts, total_views, width, height)) to improve maintainability and reduce the risk of future drift between the two implementations. Additionally, promoting magic numbers like CHART_DAYS = 30, BAR_WIDTH_DIVISOR = 32, BAR_SPACING_DIVISOR = 30, and TEXT_HEIGHT = 50 to module-level constants would improve readability.

Example refactoring:

# Module-level constants
CHART_DAYS = 30
BAR_WIDTH_DIVISOR = 32
BAR_SPACING_DIVISOR = 30
TEXT_HEIGHT = 50
BAR_COLOR = "#e05d44"
GRID_COLOR = "#eeeeee"
FAINT_BAR_COLOR = "#fcbab3"

def build_badge_image(dates, counts, total_views, width=600, height=200):
    """
    Build a badge image with a 30-day chart.
    
    Args:
        dates: List of dates
        counts: List of visit counts per date
        total_views: Total view count to display
        width: Image width in pixels
        height: Image height in pixels
    
    Returns:
        BytesIO buffer containing the PNG image
    """
    img = Image.new("RGB", (width, height), color="white")
    draw = ImageDraw.Draw(img)
    
    margin = 40
    chart_width = width - 2 * margin
    chart_height = height - 2 * margin - TEXT_HEIGHT
    
    # Calculate max count and bar dimensions
    max_count = max(counts) if counts and max(counts) > 0 else 1
    bar_width = chart_width / BAR_WIDTH_DIVISOR
    bar_spacing = chart_width / BAR_SPACING_DIVISOR
    
    # Draw grid lines
    for i in range(5):
        y = margin + TEXT_HEIGHT + (chart_height * i) // 4
        draw.line([(margin, y), (width - margin, y)], fill=GRID_COLOR)
    
    # Draw bars
    if dates and counts:
        for i, count in enumerate(counts):
            x1 = margin + (i * bar_spacing)
            x2 = x1 + bar_width
            if count > 0:
                bar_height = (count / max_count) * chart_height
                y1 = height - margin - bar_height
                y2 = height - margin
                draw.rectangle([(x1, y1), (x2, y2)], fill=BAR_COLOR)
            else:
                faint_color = FAINT_BAR_COLOR
                y1 = y2 = height - margin - 2
                draw.rectangle([(x1, y1), (x2, y2 + 1)], fill=faint_color)
    
    # Draw title text
    try:
        font = ImageFont.truetype("DejaVuSans.ttf", 28)
    except OSError:
        font = ImageFont.load_default()
    
    text = f"Total Views: {total_views}"
    text_bbox = draw.textbbox((0, 0), text, font=font)
    text_width = text_bbox[2] - text_bbox[0]
    text_x = (width - text_width) // 2
    text_y = 15
    draw.text((text_x, text_y), text, font=font, fill=BAR_COLOR)
    
    # Save to buffer
    buffer = BytesIO()
    img.save(buffer, format="PNG", optimize=True, compress_level=9)
    buffer.seek(0)
    return buffer

Then both views would simply call:

buffer = build_badge_image(dates, counts, total_views)

Also applies to: 1926-1998

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting