Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

Google Chrome is only packaged for amd64 on Linux. To ensure consistent behavior across all platforms and support ARM64 systems (Apple Silicon, ARM servers), this PR switches to using Chromium by default on all architectures.

Changes

  • Install chromium on all architectures (amd64, ARM64, etc.)
  • Create /usr/local/bin/google-chrome symlink to maintain compatibility with applications expecting the google-chrome command
  • Simplified Dockerfile by removing architecture detection logic

Implementation

# Install Chromium (works on all architectures)
RUN apt-get update && \
    apt-get install -y chromium && \
    ln -sf /usr/bin/chromium /usr/local/bin/google-chrome && \
    rm -rf /var/lib/apt/lists/*

Benefits

  • Universal support: Works on all CPU architectures (amd64, ARM64, and others)
  • Simpler code: Removed conditional architecture detection logic
  • Faster builds: No need to add Google Chrome repository
  • Consistent behavior: All platforms use the same browser (Chromium is functionally equivalent to Chrome)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Fix Dockerfile to install Chrome or Chromium based on architecture Support ARM64 architecture in Dockerfile by installing Chromium as Chrome fallback Oct 30, 2025
Copilot AI requested a review from DonnieBLT October 30, 2025 04:13
@DonnieBLT DonnieBLT marked this pull request as ready for review October 30, 2025 04:13
Copy link
Contributor

@e-esakman e-esakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. The fallback to Chromium works correctly and resolves the Chrome install issue.

@DonnieBLT
Copy link
Collaborator

@copilot lets update this to use Chromium by default

Copy link
Contributor Author

Copilot AI commented Nov 1, 2025

@copilot lets update this to use Chromium by default

Updated to use Chromium by default on all architectures. The conditional logic has been removed and now all systems will install Chromium, which works consistently across amd64, ARM64, and other platforms. Commit: 311b23e

Copilot AI changed the title Support ARM64 architecture in Dockerfile by installing Chromium as Chrome fallback Use Chromium by default in Dockerfile for all architectures Nov 1, 2025
Copy link
Contributor

@gojo-satorou-v7 gojo-satorou-v7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.

@copilot in the PR description mention issue #4731 as closed to trigger checks.

@DonnieBLT DonnieBLT merged commit f10664b into main Nov 9, 2025
11 of 12 checks passed
@DonnieBLT DonnieBLT deleted the copilot/fix-dockerfile-install-chrome branch November 9, 2025 18:53
@github-project-automation github-project-automation bot moved this from Backlog to Done in 📌 OWASP BLT Project Board Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants