Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove non-functional repository_owner condition from PR validation workflow #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonnieBLT merged 3 commits into from
Nov 1, 2025
Merged

Remove non-functional repository_owner condition from PR validation workflow #4700

DonnieBLT merged 3 commits into from
Nov 1, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 1, 2025 •
edited
Loading

The workflow condition github.actor != github.repository_owner was comparing individual usernames against the organization name "OWASP-BLT", which would never match. This made the condition ineffective—it always evaluated to true and never skipped validation as intended.

Changes

  • Removed the non-functional github.actor != github.repository_owner condition from .github/workflows/enforce-issue-number-in-description.yml
  • Repo owners like DonnieBLT remain explicitly listed as exceptions in the workflow conditions
# Before
if: >
  github.actor != 'dependabot[bot]'
  && github.actor != github.repository_owner  # Comparing username to org name
  && github.actor != 'DonnieBLT'

# After
if: >
  github.actor != 'dependabot[bot]'
  && github.actor != 'DonnieBLT'
Original prompt

skip Enforce Issue Number in PR Description / validate_pr_closing_issues (pull_request)Failing after 4s
for repo owners

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 1, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@DonnieBLT
fix: remove non-functional repository_owner comparison in PR validation
8e840b7 
The condition `github.actor != github.repository_owner` was comparing individual usernames against the organization name (OWASP-BLT), which would never match. This made the condition ineffective for skipping validation for repo owners. Individual repo owners like DonnieBLT are already explicitly listed as exceptions.

Co-authored-by: DonnieBLT <[email protected]>
Copilot AI changed the title [WIP] Fix issue number enforcement in PR description Remove non-functional repository_owner condition from PR validation workflow Nov 1, 2025
Copilot AI requested a review from DonnieBLT November 1, 2025 18:00
@DonnieBLT DonnieBLT marked this pull request as ready for review November 1, 2025 20:14
@DonnieBLT DonnieBLT merged commit efe5bce into main Nov 1, 2025
11 of 13 checks passed
@DonnieBLT DonnieBLT deleted the copilot/fix-pr-description-validation branch November 1, 2025 20:14
@github-project-automation github-project-automation bot moved this from Backlog to Done in 📌 OWASP BLT Project Board Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonnieBLT DonnieBLT Awaiting requested review from DonnieBLT

Assignees

@DonnieBLT DonnieBLT

Copilot code review Copilot

Labels

None yet

Projects

📌 OWASP BLT Project Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DonnieBLT