Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: include all reviewers in GitHubReview and fixes issue #3440 #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonnieBLT merged 2 commits into from
Nov 15, 2025
Merged

Fix: include all reviewers in GitHubReview and fixes issue #3440 #4775

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9547aac
Fix: include all reviewers in GitHubReview to populate leaderboard co…
Krishiv-Mahajan Nov 11, 2025
e12258b
fixing some errors
Krishiv-Mahajan Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 33 additions & 15 deletions website/management/commands/update_github_issues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,23 +137,41 @@ def handle(self, *args, **options):
reviews_response.raise_for_status() # Check for HTTP errors
reviews_data = reviews_response.json()

# Store reviews made by the user
# Store reviews made by ANY user (not just the PR author)
if isinstance(reviews_data, list):
for review in reviews_data:
if review.get("user") and review["user"].get("login") == github_username:
GitHubReview.objects.update_or_create(
review_id=review["id"],
defaults={
"pull_request": github_issue,
"reviewer": user,
"body": review.get("body", ""),
"state": review["state"],
"submitted_at": timezone.make_aware(
datetime.strptime(review["submitted_at"], "%Y-%m-%dT%H:%M:%SZ")
),
"url": review["html_url"],
},
)
reviewer_login = review.get("user", {}).get("login")
if reviewer_login:
# Try to find the reviewer's UserProfile
try:
# Construct the expected URL for an exact match
expected_github_url = f"https://github.com/{reviewer_login}"
reviewer_profile = UserProfile.objects.filter(
github_url__iexact=expected_github_url
).first()

if reviewer_profile:
GitHubReview.objects.update_or_create(
review_id=review["id"],
defaults={
"pull_request": github_issue,
"reviewer": reviewer_profile, # The actual reviewer, not the PR author
"body": review.get("body", ""),
"state": review["state"],
"submitted_at": timezone.make_aware(
datetime.strptime(
review["submitted_at"], "%Y-%m-%dT%H:%M:%SZ"
)
),
"url": review["html_url"],
},
)
except Exception as e:
self.stdout.write(
self.style.WARNING(
f"Could not find UserProfile for reviewer {reviewer_login}: {str(e)}"
)
)
except requests.exceptions.RequestException as e:
self.stdout.write(
self.style.ERROR(f"Error fetching reviews for PR {pr['number']}: {str(e)}")
Expand Down
Loading