Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added missing menu options #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonnieBLT merged 2 commits into from
Nov 13, 2025
Merged

added missing menu options #4787

DonnieBLT merged 2 commits into from
Nov 13, 2025

Conversation

@Nachiket-Roy
Copy link
Contributor

@Nachiket-Roy Nachiket-Roy commented Nov 12, 2025 •
edited by coderabbitai bot
Loading

closes #4785 added security labs, staking, style guide and remainder settings in menu
Screenshot 2025-11-13 034215
Screenshot 2025-11-13 034153

Summary by CodeRabbit

  • New Features
    • Added Staking, Style Guide, and Security Labs entries to the main mega-menu under Users, Resources, and Contribute respectively for easier access to those sections.
    • Added a Reminder Settings item to the sidebar navigation for quick access to notification preferences.

@Nachiket-Roy Nachiket-Roy marked this pull request as draft November 12, 2025 22:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025 •
edited
Loading

Walkthrough

Two template files were updated to add four missing navigation items: Staking, Style Guide, and Security Labs in the header mega-menu, and Reminder Settings in the sidenav. Each new item follows existing markup, icons, and conditional active/hover styling without introducing new control flow or logic.

Changes

Cohort / File(s) Summary
Header Navigation
website/templates/includes/header.html		 Added three new mega-menu links: Staking (under Users), Style Guide (under Resources), and Security Labs (under Contribute). Each entry includes an icon and link element mirroring existing item structure.
Sidenav Navigation
website/templates/includes/sidenav.html		 Added Reminder Settings nav item (bell icon) placed after Badges, using the same active/hover conditional styling and URL name reminder_settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Areas to check:
    • Confirm the referenced URL names/route targets exist (reminder_settings and header item targets).
    • Verify translation keys for new labels are present.
    • Ensure icons/assets referenced by the new items are available and render correctly.
    • Check visual spacing and hover/active styling consistency with adjacent nav items.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'added missing menu options' accurately reflects the main change of the PR, which adds missing navigation items to the menu system.
Linked Issues check ✅ Passed The PR addresses all requirements from issue #4785 by adding Security Labs, Staking, Style Guide, and Reminder Settings to the menu across header and sidenav templates.
Out of Scope Changes check ✅ Passed All changes are directly scoped to adding the four missing menu items identified in issue #4785; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between ebab726 and ee460d8.

📒 Files selected for processing (1)
  • website/templates/includes/header.html (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Run Tests
  • GitHub Check: docker-test
🔇 Additional comments (5)
website/templates/includes/header.html (5)

171-174: Staking menu item added correctly.

The new link follows the established pattern with appropriate icon (fas fa-coins), styling, and URL reference. Placement in the Users column is logical.

272-275: Style Guide menu item added correctly.

The Style Guide link uses the solid icon prefix (fas fa-palette), maintaining consistency with design conventions. Icon and placement are appropriate within the Resources column.

305-308: Security Labs menu item added correctly.

The new link uses a fitting icon (fas fa-flask) and follows the established markup pattern within the Contribute column.

192-194: Reminder Settings appears in both mega menu and user dropdown.

Line 192-194 adds Reminder Settings to the Users column in the mega menu. However, the same link also appears at lines 624-627 in the authenticated user's dropdown menu. Consider whether this duplication is intentional or if one instance should be removed to reduce redundancy.

171-174: All URL names are correctly defined in the Django URL configuration.

Verification confirms all four referenced URL names exist in blt/urls.py:

  • staking_home (line 1012)
  • style_guide (line 1111)
  • simulation_dashboard (line 368)
  • reminder_settings (line 1112)

Each URL is properly mapped to its corresponding view, so the template references will resolve correctly.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nachiket-Roy Nachiket-Roy marked this pull request as ready for review November 12, 2025 22:45
coderabbitai[bot]
coderabbitai bot requested changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e363356 and ebab726.

📒 Files selected for processing (2)
  • website/templates/includes/header.html (3 hunks)
  • website/templates/includes/sidenav.html (1 hunks)
🔇 Additional comments (4)
website/templates/includes/sidenav.html (1)

298-304: LGTM!

The Reminder Settings entry follows the established sidenav pattern: proper icon, URL reference via Django template tag, conditional active state styling, and translation string. The placement after Badges in the Users section is logical.

website/templates/includes/header.html (3)

171-174: LGTM!

Staking is properly placed in the Users column after Challenges, uses an appropriate icon, and follows the established link structure.

305-308: LGTM!

Security Labs is correctly positioned in the Contribute column with an appropriate flask icon and proper link structure.

171-174: All URL names verified in Django configuration.

All four menu item URL references have been confirmed to exist in blt/urls.py:

  • staking_home (line 1012)
  • style_guide (line 1111)
  • simulation_dashboard (line 368)
  • reminder_settings (line 1112)

Template implementation is correct.

@github-project-automation github-project-automation bot moved this from Backlog to Ready in 📌 OWASP BLT Project Board Nov 12, 2025
@DonnieBLT DonnieBLT merged commit 871e1fd into OWASP-BLT:main Nov 13, 2025
15 checks passed
@Nachiket-Roy Nachiket-Roy deleted the fix/menu-options branch November 14, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonnieBLT DonnieBLT DonnieBLT approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

📌 OWASP BLT Project Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Missing multiple fields in menu

2 participants

@Nachiket-Roy @DonnieBLT