[WIP] Fix label assignment for failed pre-commit GitHub action #4856
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pre-commit GitHub Action Label Issue ✅
The pre-commit GitHub Action was incorrectly adding the "pre-commit: passed" label even when the test failed.
Root Cause:
continue-on-error: true, which makes the step outcome always "success" even when pre-commit failssteps.pre-commit.outcomewhich would always be "success"Solution:
steps.pre-commit.outputs.exit_codeinsteadChanges made:
Result:
Security Summary:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.