Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Vanshikadahaliya
Copy link

@Vanshikadahaliya Vanshikadahaliya commented Dec 17, 2025

Fixes #3646

This PR documents an optional uv-based Python setup for BLT.

During evaluation, uv was found to have Python discovery limitations
on some Windows environments, which is now documented as well.

Existing Docker and Poetry workflows remain unchanged.

Summary by CodeRabbit

  • Documentation
    • Added an optional virtual environment setup using uv as an alternative to the existing Poetry workflow, including pip-based installation, a Windows Python-detection caveat, retention of the Python 3.11.2 prerequisite, and guidance for syncing dependencies, running migrations, and starting the development server with uv. Notes that uv may offer faster dependency resolution.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Walkthrough

Added an optional uv-based Python virtual environment setup pathway to CONTRIBUTING.md alongside the existing Poetry instructions; includes pip installation steps, Windows Python-detection caveats, and retains Python 3.11.2 prerequisites. (≈28 words)

Changes

Cohort / File(s) Summary
Documentation: contribution guide
CONTRIBUTING.md
Inserted an optional uv-based Python virtual environment setup alongside the existing Poetry workflow: installation via pip install uv, commands to uv sync and uv run (migrations/dev server), note about Windows Python-detection caveats, and preserved Python 3.11.2 prerequisite.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Review focus:
    • Verify accuracy and clarity of uv installation and usage commands (pip install uv, uv sync, uv run).
    • Validate the Windows Python-detection caveat wording and placement within the Python virtual environment section.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding optional uv-based setup documentation and Windows notes to CONTRIBUTING.md.
Linked Issues check ✅ Passed The PR documents uv as an optional setup alternative and notes Windows limitations, which aligns with the objective to investigate migrating to uv in issue #3646.
Out of Scope Changes check ✅ Passed All changes are scoped to CONTRIBUTING.md documentation for uv setup, directly supporting the uv migration investigation objective from issue #3646.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between be7f162 and 424c50c.

📒 Files selected for processing (1)
  • CONTRIBUTING.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • CONTRIBUTING.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Run Tests
  • GitHub Check: docker-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

👋 Hi @Vanshikadahaliya!

This pull request needs a peer review before it can be merged. Please request a review from a team member who is not:

  • The PR author
  • DonnieBLT
  • coderabbitai
  • copilot

Once a valid peer review is submitted, this check will pass automatically. Thank you!

@github-actions github-actions bot added the needs-peer-review PR needs peer review label Dec 17, 2025
@github-actions
Copy link
Contributor

📊 Monthly Leaderboard

Hi @Vanshikadahaliya! Here's how you rank for December 2025:

Rank User PRs Reviews Comments Total
#27 @Saptami191 1 0 0 10
#28 @Vanshikadahaliya 1 0 0 10
#29 @satvikpathak 0 0 4 8

Leaderboard based on contributions in December 2025. Keep up the great work! 🚀

@github-actions github-actions bot added pre-commit: passed Pre-commit checks passed tests: failed Django tests failed labels Dec 17, 2025
@Vanshikadahaliya
Copy link
Author

CI note: This is a documentation-only change (CONTRIBUTING.md).
The failing docker-test and test jobs appear unrelated to this PR.
Happy to rebase or update if maintainers prefer skipping CI for docs-only changes.

@Vanshikadahaliya Vanshikadahaliya marked this pull request as ready for review December 17, 2025 08:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
CONTRIBUTING.md (1)

114-161: Clarify section hierarchy and organization.

The ### Python Virtual Environment Setup header (line 114) has no direct content before the "Optional" subsection begins. The existing Poetry-based setup (starting at line 137) should be explicitly organized as a non-optional baseline or as a subsection. Consider restructuring to make the relationship between the two approaches clear:

Option A: Rename line 114 to reflect it covers Poetry, then nest both approaches:

### Python Virtual Environment Setup

#### Poetry (Recommended)
[existing content from lines 137-161]

#### Optional: Using `uv` (Fast Alternative)
[uv setup content]

Option B: If the current structure is intentional, ensure line 114 explicitly introduces the Poetry workflow as the default before discussing the optional uv alternative.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between cd7312d and 7cd76cc.

📒 Files selected for processing (1)
  • CONTRIBUTING.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Run Tests
  • GitHub Check: docker-test

@github-project-automation github-project-automation bot moved this from Backlog to Ready in 📌 OWASP BLT Project Board Dec 17, 2025
@github-actions github-actions bot added tests: passed Django tests passed and removed tests: failed Django tests failed labels Dec 17, 2025
@github-actions github-actions bot added the changes-requested PR has requested changes from a reviewer label Dec 17, 2025
@Vanshikadahaliya
Copy link
Author

All requested changes have been addressed and CodeRabbit has approved.
Kindly requesting a peer review. Thank you!

@github-actions github-actions bot added the last-active: 0d PR last updated 0 days ago label Dec 18, 2025
@mdkaifansari04
Copy link
Contributor

@Vanshikadahaliya It would be quite great if you show how you setup BLT using uv, and show working demo in video / screenshot

@github-actions github-actions bot added last-active: 0d PR last updated 0 days ago and removed last-active: 0d PR last updated 0 days ago labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes-requested PR has requested changes from a reviewer files-changed: 1 last-active: 0d PR last updated 0 days ago needs-peer-review PR needs peer review pre-commit: passed Pre-commit checks passed quality: low tests: passed Django tests passed

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

look into migrating to uv

2 participants