Monthly leaderboard #919
Merged
Monthly leaderboard #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredfalcon
suggested changes
Aug 17, 2022
fredfalcon
left a comment
There was a problem hiding this comment.
We want the monthly leaderboard (that would show top winners for a particular month and year) in addition to the global leaderboard- thanks!
Member
Author
|
@fredfalcon ok got it ill make seprate template for this UI. |
Member
Author
|
@fredfalcon Here, created new endpoint for monthly leaderboard |
fredfalcon
suggested changes
Aug 19, 2022
fredfalcon
left a comment
There was a problem hiding this comment.
Please also add spaces to {%else%} tags
Member
Author
|
@fredfalcon i added spaces as you requested, are there more changes needed in this pr ? |
fredfalcon
approved these changes
Aug 21, 2022
fredfalcon
left a comment
There was a problem hiding this comment.
Where is the link to it? Looks good
Member
Author
|
@fredfalcon the link is /leaderboard/monthly/?month=&year= |
|
@AtmegaBuzz how can a normal user get to it? Can you add a link from the normal leaderboard? |
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
* removed print statements
* report get() view changed to IssueCreate
* docs updated
* search by month leaderboard ui + backend
* monthly leaderboard with year selector
* add space in {%else%} requested changes
Co-authored-by: Fred Falcon <[email protected]>
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
* hardcoded url removed * Monthly leaderboard (#919) * removed print statements * report get() view changed to IssueCreate * docs updated * search by month leaderboard ui + backend * monthly leaderboard with year selector * add space in {%else%} requested changes Co-authored-by: Fred Falcon <[email protected]> Co-authored-by: Fred Falcon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: show monthly leaders on the leaderboard #827
implemented filter by month leaderboard