Generate Data for Monthly LeaderBoard #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f4ac26 to
e5b49bf
Compare
Contributor
Author
|
This pr is ready for review |
fredfalcon
suggested changes
Mar 12, 2023
fredfalcon
left a comment
There was a problem hiding this comment.
Can you please show a screenshot of the before and after?
Contributor
Author
|
before : after : The first one is from the api and other one is from my local system |
Member
|
I would suggest add the pagination to the response just like before, because in prod there are too many users and it will slow down the api |
Contributor
Author
|
@AtmegaBuzz ok adding the commit shortly . |
Contributor
Author
|
@AtmegaBuzz done |
Member
|
lgtm, Thanks @solo-daemon |
fredfalcon
approved these changes
Mar 13, 2023
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
* Generate Data for Monthly LeaderBoard * Update views.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1106
@fredfalcon the api for leader board was already there but was not generating the all the required fields