Created a method to hide image from public when issue is hidden #1130
Conversation
|
@fredfalcon pls, review the changes |
fredfalcon
left a comment
There was a problem hiding this comment.
Can you please setup a test to make sure this works?
is a test evolving only models is sufficient or a selenium based test is required? |
|
Only models is sufficient |
|
@fredfalcon pls check |
|
The last 6 lines of the test can be rewritten to assert true (file exists) |
|
made the changes pls check |
Made the changes please check |
made changes pls check |
|
fredfalcon
left a comment
There was a problem hiding this comment.
Please take out the try / except and unchange any code not related to the change
rectified |
fredfalcon
left a comment
There was a problem hiding this comment.
Please remove the field and clean up any unused print or code
fredfalcon
left a comment
There was a problem hiding this comment.
Looking better. Can you please remove any changes that are not directly related to your change? Because it will make it easier to review.
have removed |
removed @fredfalcon pls check |
|
Looks good to me @AtmegaBuzz can you please take a look? |
|
LGTM! @fredfalcon |
|
@fredfalcon pls merge if everything is fine |
* image rename on hide * delete from google cloude picture to be hidden * updated dependencies * wrote test for on hide signal * updated last 6 lines of the test can be rewritten to assert true * fixed remove try except * fixed remove unsused fields * file rename test and undo formatting * removed extra spaces --------- Co-authored-by: swapnil shinde <[email protected]>
fix #1104