Allow /api/v1/issues to have multiple screenshots #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredfalcon
approved these changes
Apr 7, 2023
|
Nice one. Thank you |
DonnieBLT
pushed a commit
that referenced
this pull request
Aug 12, 2023
* Allow /api/v1/issues to have multiple screenshots * Fix raising error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for https://github.com/OWASP/BLT-Flutter/issues/290
/api/v1/issueshas no logic to allow POST requests to have multiple screenshots. Therefore, only one screenshot could be linked with an issue via/api/v1/issuesI have updated the logic by creating an instance of
IssueScreenshotfor every screenshot sent to/api/v1/issuesto fix the above mentioned behavior.PS. merging this PR will break the reporting issue feature in the app, because now image files are to have
screenshotsfield rather thanscreenshot. However, I am ready with the updated code for the app, as soon as this PR is merged, I'll raise one in BLT-Flutter