Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Prakhar-Shankar
Copy link
Contributor

@Prakhar-Shankar Prakhar-Shankar commented Aug 25, 2023

Closes #1379

Add a better hovering effect on the Add Comment button.

image

Signed-off-by: Prakhar-Shankar <[email protected]>
@Prakhar-Shankar Prakhar-Shankar changed the title Fixing-hover Fixing-hover on Add Comment button Aug 25, 2023
@AtmegaBuzz
Copy link
Member

AtmegaBuzz commented Aug 25, 2023

Thanks for the PR!
.btn-small is class of bootstrap so overriding its hover would not be optimal can can make unexpected behaviour in other buttons using this class, since we are migrating to tailwind so you can just add tailwind classes in the class tag.

Eg: <button class="hover:bg-red-500">Test</button>

@Prakhar-Shankar
Copy link
Contributor Author

Thanks for the PR! .btn-small is class of bootstrap so overriding its hover would not be optimal can can make unexpected behaviour in other buttons using this class, since we are migrating to tailwind so you can just add tailwind classes in the class tag.

Eg: <button class="hover:bg-red-500">Test</button>

Sure I'll do the necessary changes.
Thanks for sharing.

Signed-off-by: Prakhar-Shankar <[email protected]>
@AtmegaBuzz
Copy link
Member

LGTM @DonnieBLT

@AtmegaBuzz AtmegaBuzz requested a review from DonnieBLT August 26, 2023 19:18
@DonnieBLT DonnieBLT enabled auto-merge August 28, 2023 15:03
@DonnieBLT DonnieBLT merged commit 606a3f2 into OWASP-BLT:main Aug 28, 2023
@Prakhar-Shankar Prakhar-Shankar deleted the adding-hover branch August 28, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: On hovering Add Comment is almost invisible

3 participants