commented out auto labellling functionality #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: website/views.py
Did you find this useful? React with a 👍 or 👎 |
DonnieBLT
previously approved these changes
Jul 1, 2024
arkid15r
reviewed
Jul 3, 2024
arkid15r
left a comment
There was a problem hiding this comment.
Would reverting the commit instead of commenting everything out work better here?
In general it's not a good practice to have commented code in the codebase.
Member
Author
|
@arkid15r Sure If you feel thats the best , the old pr can be reverted |
Collaborator
|
I think this is fine since the other PR can't be reverted and this gives some context as to what we were going for. |
…hak5598/BLT into reverting_-label_automation
DonnieBLT
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.