Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update company endpoint with companyID #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JisanAR03 merged 2 commits into from
Jul 5, 2024
Merged

update company endpoint with companyID #2401

JisanAR03 merged 2 commits into from
Jul 5, 2024

Conversation

@JisanAR03
Copy link
Contributor

@JisanAR03 JisanAR03 commented Jul 4, 2024

remove uuid from company model and also update all the endpoint for match with new model

@DonnieBLT , now company_slug using the built in integer id as unique key

arkid15r
arkid15r reviewed Jul 5, 2024
View reviewed changes
Copy link

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for refactoring this!

I suggest renaming id/company params in views definitions to company_id where applicable for better readability (e.g. here)

DonnieBLT
DonnieBLT approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JisanAR03 JisanAR03 merged commit c2f028a into OWASP-BLT:main Jul 5, 2024
@JisanAR03 JisanAR03 mentioned this pull request Jul 5, 2024
Closed
@JisanAR03 JisanAR03 deleted the company_slug_update branch July 9, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonnieBLT DonnieBLT DonnieBLT approved these changes

@AtmegaBuzz AtmegaBuzz Awaiting requested review from AtmegaBuzz

+1 more reviewer

@arkid15r arkid15r arkid15r left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JisanAR03 @arkid15r @DonnieBLT